59 lines
1.8 KiB
Diff
59 lines
1.8 KiB
Diff
diff -rupN --no-dereference binutils-2.34/bfd/dwarf2.c binutils-2.34-new/bfd/dwarf2.c
|
|
--- binutils-2.34/bfd/dwarf2.c 2020-01-18 14:55:47.000000000 +0100
|
|
+++ binutils-2.34-new/bfd/dwarf2.c 2021-04-12 11:40:29.676218279 +0200
|
|
@@ -523,22 +523,24 @@ read_section (bfd * abfd,
|
|
bfd_byte ** section_buffer,
|
|
bfd_size_type * section_size)
|
|
{
|
|
- asection *msec;
|
|
const char *section_name = sec->uncompressed_name;
|
|
bfd_byte *contents = *section_buffer;
|
|
- bfd_size_type amt;
|
|
|
|
/* The section may have already been read. */
|
|
if (contents == NULL)
|
|
{
|
|
+ bfd_size_type amt;
|
|
+ asection *msec;
|
|
+ ufile_ptr filesize;
|
|
+
|
|
msec = bfd_get_section_by_name (abfd, section_name);
|
|
- if (! msec)
|
|
+ if (msec == NULL)
|
|
{
|
|
section_name = sec->compressed_name;
|
|
if (section_name != NULL)
|
|
msec = bfd_get_section_by_name (abfd, section_name);
|
|
}
|
|
- if (! msec)
|
|
+ if (msec == NULL)
|
|
{
|
|
_bfd_error_handler (_("DWARF error: can't find %s section."),
|
|
sec->uncompressed_name);
|
|
@@ -546,12 +548,23 @@ read_section (bfd * abfd,
|
|
return FALSE;
|
|
}
|
|
|
|
- *section_size = msec->rawsize ? msec->rawsize : msec->size;
|
|
+ amt = bfd_get_section_limit_octets (abfd, msec);
|
|
+ filesize = bfd_get_file_size (abfd);
|
|
+ if (amt >= filesize)
|
|
+ {
|
|
+ /* PR 26946 */
|
|
+ _bfd_error_handler (_("DWARF error: section %s is larger than its filesize! (0x%lx vs 0x%lx)"),
|
|
+ section_name, (long) amt, (long) filesize);
|
|
+ bfd_set_error (bfd_error_bad_value);
|
|
+ return FALSE;
|
|
+ }
|
|
+ *section_size = amt;
|
|
/* Paranoia - alloc one extra so that we can make sure a string
|
|
section is NUL terminated. */
|
|
- amt = *section_size + 1;
|
|
+ amt += 1;
|
|
if (amt == 0)
|
|
{
|
|
+ /* Paranoia - this should never happen. */
|
|
bfd_set_error (bfd_error_no_memory);
|
|
return FALSE;
|
|
}
|